Re: [dpdk-dev] [EXT] Re: [PATCH 00/39] adding eventmode helper library

-----Original Message-----
From: Anoob Joseph
Sent: Tuesday, July 2, 2019 7:47 PM
To: Thomas Monjalon <redacted>; Jerin Jacob Kollanukkaran
[off-list ref]
Cc: dev@dpdk.org; Mattias Rönnblom <redacted>;
Nikhil Rao [off-list ref]; Erik Gabriel Carrillo
[off-list ref]; Abhinandan Gujjar [off-list ref];
Bruce Richardson [off-list ref]; Pablo de Lara
[off-list ref]; Narayana Prasad Raju Athreya
[off-list ref]; Lukas Bartosik [off-list ref]; Pavan
Nikhilesh Bhagavatula [off-list ref]; Hemant Agrawal
[off-list ref]; Nipun Gupta [off-list ref]; Harry van
Haaren [off-list ref]; Liang Ma [off-list ref];
techboard@dpdk.org
Subject: RE: [dpdk-dev] [EXT] Re: [PATCH 00/39] adding eventmode helper
library

Hi Thomas, Jerin,

Is there any consensus on how we should proceed? Can this be taken up by
techboard?

For me it make sense to  move these helper functions to examples/.. and make it as standalone(not as library)
Suggested directory(In the order of my preference). No strong preference on the directory name though
1) examples/helper  or
2) examples/common or
3) examples/utils

Thomas? Bruce?

Thanks,
Anoob

quoted

-----Original Message-----
From: dev <redacted> On Behalf Of Anoob Joseph
Sent: Friday, June 28, 2019 5:04 PM
To: Thomas Monjalon <redacted>; Jerin Jacob Kollanukkaran
[off-list ref]
Cc: dev@dpdk.org; Mattias Rönnblom <redacted>;
Nikhil Rao [off-list ref]; Erik Gabriel Carrillo
[off-list ref]; Abhinandan Gujjar
[off-list ref]; Bruce Richardson
[off-list ref]; Pablo de Lara
[off-list ref]; Narayana Prasad Raju Athreya
[off-list ref]; Lukas Bartosik [off-list ref]; Pavan
Nikhilesh Bhagavatula [off-list ref]; Hemant Agrawal
[off-list ref]; Nipun Gupta [off-list ref]; Harry

van

quoted

Haaren [off-list ref]; Liang Ma [off-list ref];
techboard@dpdk.org
Subject: Re: [dpdk-dev] [EXT] Re: [PATCH 00/39] adding eventmode
helper library

Hi Thomas, Jerin,

quoted

-----Original Message-----
From: dev <redacted> On Behalf Of Thomas Monjalon
Sent: Friday, June 28, 2019 2:10 PM
To: Jerin Jacob Kollanukkaran <redacted>; Anoob Joseph
[off-list ref]
Cc: dev@dpdk.org; Mattias Rönnblom <redacted>;
Nikhil Rao [off-list ref]; Erik Gabriel Carrillo
[off-list ref]; Abhinandan Gujjar
[off-list ref]; Bruce Richardson
[off-list ref]; Pablo de Lara
[off-list ref]; Narayana Prasad Raju Athreya
[off-list ref]; Lukas Bartosik [off-list ref];
Pavan Nikhilesh Bhagavatula [off-list ref]; Hemant
Agrawal [off-list ref]; Nipun Gupta

[off-list ref];

quoted

quoted

Harry

van

quoted

Haaren [off-list ref]; Liang Ma
[off-list ref]; techboard@dpdk.org
Subject: [EXT] Re: [dpdk-dev] [PATCH 00/39] adding eventmode helper
library

External Email

--------------------------------------------------------------------
--
28/06/2019 05:37, Jerin Jacob Kollanukkaran:

quoted

From: Anoob Joseph

quoted

From: Jerin Jacob Kollanukkaran

quoted

From: Anoob Joseph

quoted

The helper library will be experimental while we add
event-mode support for other applications like l3fwd &
ipsec-secgw. I expect the helper library to be complete over
the course of those applications also using the helper library.

You are doing a copy of l2fwd example to add event mode.
It was the decision from the techboard to not complicate the original l2fwd.
But it makes me nervous to see some code duplicated, especially if
you plan to do the same for l3fwd and ipsec-secgw.
We are not going to duplicate every examples. We should re-consider.

[Anoob] For l3fwd & ipsec-secgw, the plan is to add eventmode in the
original application itself. If you have concerns about code
duplication in l2fwd-event, the changes can be added to l2fwd itself. Please

advise on how to proceed.

quoted

quoted

quoted

quoted

quoted

I have only concern about moving this as library inside
eventdev that till we have mature version of helper library
the eventdev library ABI will not stable(i.e .so file version
needs to be incremented as when a change needed). Which align
with Mattias thoughts for some other reason:. How about moving
this code to
1) example/common or
2) to specific application itself, once at least two
applications starts using it then move to Eventdev library.

Thoughts?

[Anoob] Either location is not a problem if there is a consensus.
Earlier the suggestion was to move it to library (when the patch
was submitted with changes added in app).

If there is only one user, making it grow in the application looks
to be the best thing to do.
Should we use it in more applications before it is more mature?
If not, we could move the code in eventdev library when we will use
it in more examples.

[Anoob] The proposal with l2fwd-event was to present an easy enough
example so that the APIs can be decided before moving onto complex

examples.

quoted

Additions to l3fwd & ipsec-secgw is in the pipeline.

quoted

quoted

If there NO objections then lets move to example/common.

If we really want to have this library standalone in examples, I
suggest to give it a name and not use a "common" directory.

[Anoob] I would suggest to add the eventmode code in 'examples/utils'.

What is being added here can be treated as a utility library. Almost
all examples have duplicated code for the entire conf parsing, ethdev
init etc. Anyone who would attempt a new application will have to
duplicate lot of code. So a similar exercise with regular poll mode is also

possible.

quoted

As for build, we will have the following options,

1. From the examples/<example>/Makefile, build *helper*.o files (
'../utils/eventmode_helper.o') and prepare the binary. So each
application will build its own version of *helper*.c
    +SRCS-y += ../utils/eventmode_helper.c

2. Make 'examples/utils' a separate library. This way, all
applications can directly link without having to build separately.

Please do suggest on which would be a good way to execute.

Thanks,
Anoob