Re: [dpdk-dev] [EXT] Re: [PATCH 24/39] eventdev: add Rx adapter init in eventmode

Hi Erik,

Please see inline.

Thanks,
Anoob

-----Original Message-----
From: dev <redacted> On Behalf Of Carrillo, Erik G
Sent: Monday, June 10, 2019 8:26 PM
To: Anoob Joseph <redacted>; Jerin Jacob Kollanukkaran
[off-list ref]; Rao, Nikhil [off-list ref]; Gujjar,
Abhinandan S [off-list ref]; Richardson, Bruce
[off-list ref]; De Lara Guarch, Pablo
[off-list ref]
Cc: Narayana Prasad Raju Athreya <redacted>; <redacted>;
Lukas Bartosik [off-list ref]; Pavan Nikhilesh Bhagavatula
[off-list ref]; Hemant Agrawal
[off-list ref]; Nipun Gupta [off-list ref]; Van
Haaren, Harry [off-list ref]; Mattias Rönnblom
[off-list ref]; Ma, Liang J [off-list ref]
Subject: [EXT] Re: [dpdk-dev] [PATCH 24/39] eventdev: add Rx adapter init in
eventmode

External Email

----------------------------------------------------------------------

quoted

-----Original Message-----
From: Anoob Joseph <redacted>
Sent: Monday, June 3, 2019 12:32 PM
To: Jerin Jacob <redacted>; Rao, Nikhil
[off-list ref]; Carrillo, Erik G [off-list ref];
Gujjar, Abhinandan S [off-list ref]; Richardson, Bruce
[off-list ref]; De Lara Guarch, Pablo
[off-list ref]
Cc: Anoob Joseph <redacted>; Narayana Prasad
[off-list ref]; dev@dpdk.org; Lukasz Bartosik
[off-list ref]; Pavan Nikhilesh [off-list ref];
Hemant Agrawal [off-list ref]; Nipun Gupta
[off-list ref]; Van Haaren, Harry

[off-list ref];

quoted

Mattias Rönnblom [off-list ref]; Ma, Liang J
[off-list ref]
Subject: [PATCH 24/39] eventdev: add Rx adapter init in eventmode

Adding rx adapter conf. The helper init routine would be initializing
the rx adapter according to the conf.

Signed-off-by: Anoob Joseph <redacted>
Signed-off-by: Lukasz Bartosik <redacted>
---

<...Snipped...>

quoted

diff --git a/lib/librte_eventdev/rte_eventmode_helper_internal.h

b/lib/librte_eventdev/rte_eventmode_helper_internal.h
index 2a6cd90..9c68605 100644

--- a/lib/librte_eventdev/rte_eventmode_helper_internal.h
+++ b/lib/librte_eventdev/rte_eventmode_helper_internal.h

@@ -35,6 +35,12 @@
 /* Max event devices supported */
 #define EVENT_MODE_MAX_EVENT_DEVS RTE_EVENT_MAX_DEVS

+/* Max Rx adapters supported */
+#define EVENT_MODE_MAX_RX_ADAPTERS RTE_EVENT_MAX_DEVS
+
+/* Max Rx adapter connections */
+#define EVENT_MODE_MAX_CONNECTIONS_PER_ADAPTER 16
+
 /* Max event queues supported per event device */  #define

EVENT_MODE_MAX_EVENT_QUEUES_PER_DEV
RTE_EVENT_MAX_QUEUES_PER_DEV

@@ -50,12 +56,33 @@ struct eventdev_params {
 	uint8_t ev_queue_mode;
 };

Should the struct below be named "rx_adapter_connection_info" since you
add "tx_adapter_connection_info" in a later patch?

[Anoob] Yes. Will make this change in v2.

quoted

+/* Rx adapter connection info */
+struct adapter_connection_info {
+	uint8_t ethdev_id;
+	uint8_t eventq_id;
+	int32_t ethdev_rx_qid;
+};
+
+/* Rx adapter conf */
+struct rx_adapter_conf {
+	int32_t eventdev_id;
+	int32_t adapter_id;
+	uint32_t rx_core_id;
+	uint8_t nb_connections;
+	struct adapter_connection_info
+
	conn[EVENT_MODE_MAX_CONNECTIONS_PER_ADAPTER];
+};
+

<...Snipped...>

Regards,
Erik