Thread (8 messages) 8 messages, 3 authors, 2019-06-27

Re: [dpdk-dev] [dpdk-stable] [PATCH] eal: correct error log for alarm

From: Ye Xiaolong <hidden>
Date: 2019-06-05 06:58:06

On 06/05, David Marchand wrote:
Hello,

On Tue, Jun 4, 2019 at 6:41 PM Xiaolong Ye [off-list ref] wrote:
quoted
Fixes: af75078fece3 ("first public release")
Cc: stable@dpdk.org

Signed-off-by: Xiaolong Ye <redacted>
---
 lib/librte_eal/linux/eal/eal.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/lib/librte_eal/linux/eal/eal.c
b/lib/librte_eal/linux/eal/eal.c
index 161399619..10e2887ca 100644
--- a/lib/librte_eal/linux/eal/eal.c
+++ b/lib/librte_eal/linux/eal/eal.c
@@ -1006,7 +1006,7 @@ rte_eal_init(int argc, char **argv)
        }

        if (rte_eal_alarm_init() < 0) {
-               rte_eal_init_alert("Cannot init interrupt-handling
thread");
+               rte_eal_init_alert("Cannot init alarm");
                /* rte_eal_alarm_init sets rte_errno on failure. */
                return -1;
        }
--
2.17.1
The same applies to freebsd eal.

lib/librte_eal/freebsd/eal/eal.c:       if (rte_eal_alarm_init() < 0) {
lib/librte_eal/freebsd/eal/eal.c-               rte_eal_init_alert("Cannot
init interrupt-handling thread");
Er, yes, do I need to make another separate patch or just add the freebsd fix
into this patch?

Thanks,
Xiaolong

-- 
David Marchand
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help