Re: [PATCH v2 3/8] net/ice: support vector SSE in RX
From: Lu, Wenzhuo <hidden>
Date: 2019-03-15 01:50:33
Hi Qi,
-----Original Message----- From: Zhang, Qi Z Sent: Monday, March 11, 2019 11:27 AM To: Lu, Wenzhuo <redacted>; dev@dpdk.org Cc: Lu, Wenzhuo <redacted> Subject: RE: [dpdk-dev] [PATCH v2 3/8] net/ice: support vector SSE in RX Hi:quoted
-----Original Message----- From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Wenzhuo Lu Sent: Monday, March 4, 2019 2:53 PM To: dev@dpdk.org Cc: Lu, Wenzhuo <redacted> Subject: [dpdk-dev] [PATCH v2 3/8] net/ice: support vector SSE in RX Signed-off-by: Wenzhuo Lu <redacted> ---.....quoted
+ + if (!ice_rx_vec_dev_check(dev)) { + for (i = 0; i < dev->data->nb_rx_queues; i++) { + rxq = dev->data->rx_queues[i]; + (void)ice_rxq_vec_setup(rxq); + } + PMD_DRV_LOG(DEBUG, "Using Vector Rx (port %d).", + dev->data->port_id); + dev->rx_pkt_burst = ice_recv_pkts_vec; + + return; + } +#endifSince vPMD is only implemented on x86, I think the logic to setup vector path could be wrapped by compile option #ifdef ARCH_X86, otherwise I guess there will be some compile error on other platform, for example the function ice_rx_vec_dev_check is only defined in ice_rxtx_vec_sse.c
Thanks for the comments. There should be compile errors if x86 not supported. Will send a V3.