Thread (5 messages) 5 messages, 4 authors, 2019-03-28

Re: [PATCH v2] hash: optimize signature compare by using neon intrinsic

From: Wang, Yipeng1 <hidden>
Date: 2019-02-13 20:31:56

Hi, Ruifeng,

I don't have an ARM Platform at hand to test but I gone through the code against a NEON instruction manual, 
and the logic looks good to me. One small comment is the coding style for switch case, I think it is more common
to leave the braces on their own lines.

Otherwise:
Acked-by: Yipeng Wang<redacted>

-----Original Message-----
From: Ruifeng Wang [mailto:ruifeng.wang@arm.com]
Sent: Monday, February 11, 2019 11:01 PM
To: Wang, Yipeng1 <redacted>; jerinj@marvell.com
Cc: dev@dpdk.org; honnappa.nagarahalli@arm.com; gavin.hu@arm.com; nd@arm.com; Ruifeng Wang <redacted>
Subject: [PATCH v2] hash: optimize signature compare by using neon intrinsic

Implemented signature compare function based on neon intrinsic.
Hash bulk lookup had 3% - 6% performance gain after optimization.

Signed-off-by: Ruifeng Wang <redacted>
Reviewed-by: Gavin Hu <redacted>
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help