Re: [PATCH] build: add option to override max ethports

On 1/31/19 4:32 AM, Bruce Richardson wrote:

On Wed, Jan 30, 2019 at 09:18:58PM -0500, Chas Williams wrote:

quoted

Allow users and packagers to override the default RTE_MAX_ETHPORTS.
This adds a new meson option, max_ethports which defaults to the
current value.

Signed-off-by: Chas Williams <3chas3@gmail.com>

Agree with the idea. Just one small comment below re alphabetical order.

Otherwise:
Acked-by: Bruce Richardson <redacted>

...

We are trying to keep the options in alphabetical order, so this setting
should be just before "max_lcores" rather than at the end.

If you look at the last few lines in this file:

	option('use_hpet', type: 'boolean', value: false,
		description: 'use HPET timer in EAL')
	option('tests', type: 'boolean', value: true,
		description: 'build unit tests')

I couldn't detect any ordering so I just appended.  I can submit a v2.

Interestingly, I see that since 0.45 there is now the option of an
"integer" option type. We should probably switch to use that once we bump
our minimum meson version. [Luca, perhaps another change for your set?]
Ref: http://mesonbuild.com/Build-options.html#integers

I just followed along with what everyone else was doing.