Re: [PATCH] hash: fix out-of-bound write while freeing key slot
From: Thomas Monjalon <hidden>
Date: 2018-12-21 00:47:21
From: Thomas Monjalon <hidden>
Date: 2018-12-21 00:47:21
20/12/2018 14:59, Bruce Richardson:
On Wed, Nov 21, 2018 at 08:51:56PM -0600, Honnappa Nagarahalli wrote:quoted
Add a debug check for out-of-bound write while freeing the key slot. Coverity issue: 325733 Fixes: e605a1d36ca7 ("hash: add lock-free r/w concurrency") Cc: honnappa.nagarahalli@arm.com Signed-off-by: Honnappa Nagarahalli <redacted> Reviewed-by: Steve Capper <redacted> Reviewed-by: Gavin Hu <redacted> --- lib/librte_hash/rte_cuckoo_hash.c | 4 ++++ lib/librte_hash/rte_cuckoo_hash.h | 11 +++++++++++ 2 files changed, 15 insertions(+)While I think enqueuing a free slot should ever fail, I don't see an issue with having a check for that. Acked-by: Bruce Richardson <redacted>
Applied, thanks