-----Original Message-----
From: Thomas Monjalon [mailto:thomas@monjalon.net]
Sent: Tuesday, December 18, 2018 12:38 PM
To: Dumitrescu, Cristian <redacted>
Cc: Pattan, Reshma <redacted>; dev@dpdk.org; Ananyev,
Konstantin [off-list ref];
jerin.jacob@caviumnetworks.com; Singh, Jasvinder
[off-list ref]; david.marchand@redhat.com;
olivier.matz@6wind.com
Subject: Re: [dpdk-dev] [PATCH v2 2/3] eal: add new rte color definition

18/12/2018 12:18, Dumitrescu, Cristian:

quoted

quoted

quoted

I replied in v3 that it should stay in rte_meter.h.
You can include rte_meter.h in ethdev.

OK, thanks Thomas, makes sense to me as well.

Thomas,

I agree with your input, but just want to make sure we are on the same

page:

quoted

Besides including rte_meter.h in ethdev (which you are fine with), we

would also need to include rte_meter.h in mbuf.

quoted

Are you OK with this as well?

Why do we need rte_meter.h in mbuf?

You probably looked at V2 only, but in V3 we have functions to set/get the color within the mbuf->hash.sched field.

For space compression reasons, the mbuf->hash.sched stores the color on 8-bit variable, while for the outside world the set/get functions work with the 32-bit enum type. We do same thing in other places in DPDK, such as rte_crypto_op, etc.