Re: [PATCH v13 09/10] net/virtio-user: fail if q used with packed vq

On Mon, Dec 17, 2018 at 05:52:08PM +0100, Maxime Coquelin wrote:

I think you meant control queue in the title?

On 12/14/18 4:59 PM, Jens Freimann wrote:

quoted

Until we have support for ctrl virtqueues let's disable it and
fail device initalization if specified as a parameter.

Signed-off-by: Jens Freimann <redacted>
---
 drivers/net/virtio/virtio_user/virtio_user_dev.c | 10 ++++++++--
 1 file changed, 8 insertions(+), 2 deletions(-)

diff --git a/drivers/net/virtio/virtio_user/virtio_user_dev.c b/drivers/net/virtio/virtio_user/virtio_user_dev.c
index 697ba4ae8..14597eb73 100644
--- a/drivers/net/virtio/virtio_user/virtio_user_dev.c
+++ b/drivers/net/virtio/virtio_user/virtio_user_dev.c

@@ -467,10 +467,16 @@ virtio_user_dev_init(struct virtio_user_dev *dev, char *path, int queues,
 	if (!in_order)
 		dev->unsupported_features |= (1ull << VIRTIO_F_IN_ORDER);
-	if (packed_vq)
+	if (packed_vq) {
+		if (cq) {
+			PMD_INIT_LOG(ERR, "control vq not supported with "

Maybe change to "not supported *yet*".

sure, no problem. 

regards,
Jens