Re: [PATCH] compress/qat: fix out-of-bounds error
From: Bruce Richardson <hidden>
Date: 2018-11-01 14:16:55
On Wed, Oct 31, 2018 at 06:35:11AM +0000, Jerin Jacob wrote:
-----Original Message-----quoted
Date: Wed, 31 Oct 2018 00:39:54 +0000 From: Fiona Trahe <redacted> To: dev@dpdk.org CC: thomas@monjalon.net, akhil.goyal@nxp.com, tomaszx.jozwiak@intel.com, jerin.jacob@caviumnetworks.com, Fiona Trahe [off-list ref] Subject: [PATCH] compress/qat: fix out-of-bounds error X-Mailer: git-send-email 1.7.0.7 QAT array for sgls in intermediate buffer structure was #defined to 1, but setup code hardcoded as if 2 buffers so causing out of bounds write. Reworked to loop correctly using #define. Fixes: a124830a6f00 ("compress/qat: enable dynamic huffman encoding") Reported-by: Jerin Jacob <redacted> Signed-off-by: Fiona Trahe <redacted>clang build is not reproducible with this patch.
s/not/now/ :-)
Tested-by: Jerin Jacob <redacted>
I can also confirm that clang builds which were failing without this patch are now building ok on Fedora 29. Acked-by: Bruce Richardson <redacted>