Thread (4 messages) 4 messages, 2 authors, 2018-10-31

Re: [PATCH v2] bus/pci: fix unexpected resource mapping override

From: Zhang, Qi Z <hidden>
Date: 2018-10-30 15:19:54

-----Original Message-----
From: Thomas Monjalon [mailto:thomas@monjalon.net]
Sent: Sunday, October 28, 2018 6:27 PM
To: Zhang, Qi Z <redacted>
Cc: dev@dpdk.org; Burakov, Anatoly <redacted>; Yigit,
Ferruh [off-list ref]; geoffrey.lv@gmail.com;
ajit.khaparde@broadcom.com; stable@dpdk.org; gaetan.rivet@6wind.com;
arybchenko@solarflare.com
Subject: Re: [dpdk-dev] [PATCH v2] bus/pci: fix unexpected resource mapping
override

27/10/2018 05:20, Qi Zhang:
quoted
When scanning an already plugged device, the virtual address of mapped
PCI resource in rte_pci_device will be overridden with 0, that may
cause driver does not work correctly.
The fix is not to update any rte_pci_device's field if the being
scanned device's driver is already probed.

Bugzilla ID: 85
Fixes: c752998b5e2e ("pci: introduce library and driver")
Cc: stable@dpdk.org

Reported-by: Lv Geoffrey <redacted>
Signed-off-by: Qi Zhang <redacted>
I still think something must be fixed in PCI scan.
We are fixing something in PCI scan, right?
Anyway, there is an error:
passing argument 1 of ‘rte_dev_is_probed’ from incompatible pointer type
So sorry, I should compile it first
.
  
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help