-----Original Message-----
From: Stojaczyk, Dariusz
Sent: Monday, October 29, 2018 7:02 AM
To: Burakov, Anatoly <redacted>; dev@dpdk.org
Cc: Zhang, Qi Z <redacted>; stable@dpdk.org
Subject: RE: [dpdk-dev] [PATCH] eal: fix rte_mp_request_sync() memleak on
device hotplug

quoted

-----Original Message-----
From: Burakov, Anatoly
Sent: Friday, October 26, 2018 4:22 PM
To: Stojaczyk, Dariusz <redacted>; dev@dpdk.org
Cc: Zhang, Qi Z <redacted>; stable@dpdk.org
Subject: Re: [dpdk-dev] [PATCH] eal: fix rte_mp_request_sync() memleak
on device hotplug

<SNIP>

This is correct but incomplete. There are also numerous error
conditions which check for number of received responses to be a
particular number, and if the number don't match, we just exit without

freeing memory.

quoted

Those errors need to free the memory as well.

Yup, thanks. I pushed v2 with one extra free() in the function notifying
secondary processes.
The function which notifies the primary process has a similar error check -
 - `if (mp_reply.nb_received == 1)`  - but I figured if there's more than 1
primary process replying, then the memory leak is your smallest problem.

Good capture!
Thanks for fix this.

quoted

--
Thanks,
Anatoly