Thread (7 messages) 7 messages, 4 authors, 2018-09-27

Re: [PATCH v2] vhost: fix corner case for enqueue operation

From: Maxime Coquelin <hidden>
Date: 2018-09-27 12:38:03


On 09/27/2018 02:24 PM, Maxime Coquelin wrote:

On 09/17/2018 05:54 AM, Jiayu Hu wrote:
quoted
When perform enqueue operations on the split and packed ring,
s/perform/performing/
s/ring/rings/
quoted
if the reserved buffer length from the descriptor table execeeds
65535, the returned length by fill_vec_buf_split/_packed() is
overflowed. This patch is to avoid this corner case.
s/overflowed/overflows/
quoted
Fixes: f689586b ("vhost: shadow used ring update")
Fixes: fd68b473 ("vhost: use buffer vectors in dequeue path")
Fixes: 2f3225a7 ("vhost: add vector filling support for packed ring")
Fixes: 37f5e79a ("vhost: add shadow used ring support for packed rings")
Fixes: a922401f ("vhost: add Rx support for packed ring")
Fixes: ae999ce4 ("vhost: add Tx support for packed ring")

Signed-off-by: Jiayu Hu <redacted>
---
  lib/librte_vhost/virtio_net.c | 20 +++++++++++---------
  1 file changed, 11 insertions(+), 9 deletions(-)
Other than that, the patch looks good to me. Thanks for fixing it.

Reviewed-by: Maxime Coquelin <redacted>

Maxime
Applied to dpdk-next-virtio/master with commit message fix.

Thanks,
Maxime
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help