Thread (107 messages) 107 messages, 7 authors, 2018-10-25

Re: [PATCH v2 1/7] test/hash: fix bucket size in hash perf test

From: Honnappa Nagarahalli <hidden>
Date: 2018-09-27 04:23:32

quoted hunk ↗ jump to hunk
-----Original Message-----
From: Yipeng Wang <redacted>
Sent: Friday, September 21, 2018 12:17 PM
To: bruce.richardson@intel.com
Cc: dev@dpdk.org; yipeng1.wang@intel.com; michel@digirati.com.br;
Honnappa Nagarahalli [off-list ref]
Subject: [PATCH v2 1/7] test/hash: fix bucket size in hash perf test

The bucket size was changed from 4 to 8 but the corresponding perf test was
not changed accordingly.

Fixes: 58017c98ed53 ("hash: add vectorized comparison")
Cc: stable@dpdk.org

Signed-off-by: Yipeng Wang <redacted>
---
 test/test/test_hash_perf.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/test/test/test_hash_perf.c b/test/test/test_hash_perf.c index
33dcb9f..9ed7125 100644
--- a/test/test/test_hash_perf.c
+++ b/test/test/test_hash_perf.c
@@ -20,7 +20,7 @@
 #define MAX_ENTRIES (1 << 19)
 #define KEYS_TO_ADD (MAX_ENTRIES * 3 / 4) /* 75% table utilization */
#define NUM_LOOKUPS (KEYS_TO_ADD * 5) /* Loop among keys added,
several times */ -#define BUCKET_SIZE 4
+#define BUCKET_SIZE 8
May be we should add a comment to warn that it should be same as ' RTE_HASH_BUCKET_ENTRIES'?
 #define NUM_BUCKETS (MAX_ENTRIES / BUCKET_SIZE)  #define
MAX_KEYSIZE 64  #define NUM_KEYSIZES 10
--
2.7.4
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help