Re: [PATCH v13] devtools: alert on new instances of rte_panic and rte_exit

On Tue, Jul 31, 2018 at 2:38 PM, Thomas Monjalon [off-list ref] wrote:

27/07/2018 00:10, Arnon Warshavsky:

quoted

This patch adds a new function that is called
per every checked patch,
and alerts for new instances of rte_panic/rte_exit.
The check excludes comments, and alerts in the case
of a positive balance between additions and removals.

Signed-off-by: Arnon Warshavsky <redacted>
Reviewed-by: Stephen Hemminger <stephen@networkplumber.org>
Tested-by: Kevin Traynor <redacted>

Applied, with small adjustments, thanks

I get some warning when running this on Ubuntu 18.04.

marchand@gribouille:~/git/dpdk$ ./devtools/checkpatches.sh
sanity/0001-mbuf-add-sanity-checks-on-segment-metadata.patch
./devtools/checkpatches.sh: 52: read: Illegal option -d

1/1 valid patch


+ false
+ check_forbidden_additions
+ read -d  awk_script
./devtools/checkpatches.sh: 52: read: Illegal option -d
+ awk -v FOLDERS=lib drivers -v EXPRESSIONS=rte_panic\\( rte_exit\\(
-v RET_ON_FAIL=1  -
+ report=
+ [ 0 -ne 0 ]


-- 
David Marchand