Hi Thomas,

-----Original Message-----
From: Pattan, Reshma
Sent: Friday, August 03, 2018 7:15 PM
To: Thomas Monjalon <redacted>; Somarowthu, Naga SureshX
[off-list ref]
Cc: dev@dpdk.org; Burakov, Anatoly <redacted>;
Parthasarathy, JananeeX M [off-list ref]
Subject: RE: [dpdk-dev] [PATCH v10 0/5] add unit tests for bitrate, latency and
pdump libraries

Hi Thomas,

quoted

-----Original Message-----
From: Thomas Monjalon [mailto:thomas@monjalon.net]
Sent: Wednesday, August 1, 2018 8:52 AM
To: Pattan, Reshma <redacted>
Cc: dev@dpdk.org; Burakov, Anatoly <redacted>;
Parthasarathy, JananeeX M [off-list ref];
Somarowthu, Naga SureshX [off-list ref]
Subject: Re: [dpdk-dev] [PATCH v10 0/5] add unit tests for bitrate,
latency and pdump libraries

01/08/2018 00:18, Reshma Pattan:

quoted

v10: fixed clang compiler issues and freed latency stats memzone in
latency stats unit tests.
v9: rebased ontop of latest autotest changes and added new tests to
the autotest list
v8: renamed commit headline and freed the metrics memzone for
bitrate ut
v7: removed unused macros and corrected the comment
v6: updated ring variable appropriately
v5: rebased, freed pools and rings, created common patch set
---

Sorry, the integration of this patchset is very painful.

After asking for rebase, for clang fix, there are still some basic
errors with 32- bit compilation:

	test_latencystats.c:131:21: error:
	format ‘%ld’ expects argument of type ‘long int’,
	but argument 2 has type ‘uint64_t’ {aka ‘long long unsigned int’}

linkage:

	test@test@@dpdk-test@exe/test.c.o:(.data+0x18): undefined

reference

quoted

to `test_pdump'

or even MAINTAINERS file:

	test/test/sample_packet_forward.c
	test/test/sample_packet_forward.h
	test/test/test_bitratestats.c
	test/test/test_latencystats.c

I have already spent too much time on it, despite it is not fixing 18.08.

Please do a complete detailed review of this series, so it can be
considered for 18.11.

We missed to do these basic checks, apologies for consuming your time.
Naga Suresh has now proactively worked on fixing these issues and running
pre checks on patches and addressed in v12.
The earlier versions were reviewed by me, Remy and Anatoly . So we request
you to consider latest patches for 18.08, until unless they don’t give any last
minute  surprises.

Thanks,
Reshma

Apologies very much to miss the earlier patch pre-checks.
We have gone through the cheatsheet and validated pre-checks in the patch v12.
Compiled Successfully in Fedora 27, Fedora 26, CentOS 7.2, CentOS 7.4, Ubuntu for both 32bit/64bit and FreeBSD (64bit)
Build using compilers gcc, icc, clang were successful in Fedora.
Shared Library builds were successful in Fedora 27, CentOS 7.2 and Ubuntu

Executed checkpatch, check-git-log without any errors.
Code changes were acknowledged by reviewers.

Request to please consider the patch set v12 to be included in RC3 18.08.

In case of any info/change please let us know.

Thanks for your support.
M.P.Jananee
--------------------------------------------------------------
Intel Research and Development Ireland Limited
Registered in Ireland
Registered Office: Collinstown Industrial Park, Leixlip, County Kildare
Registered Number: 308263


This e-mail and any attachments may contain confidential material for the sole
use of the intended recipient(s). Any review or distribution by others is
strictly prohibited. If you are not the intended recipient, please contact the
sender and delete all copies.