Thread (46 messages) 46 messages, 6 authors, 2018-10-04
STALE2808d

[PATCH v2 6/7] ethdev: deprecate rte_flow_copy function

From: Adrien Mazarguil <hidden>
Date: 2018-08-03 13:37:01
Subsystem: library code, the rest · Maintainers: Andrew Morton, Linus Torvalds

No users left for this function, time to deprecate it.

Signed-off-by: Adrien Mazarguil <redacted>
Cc: Thomas Monjalon <redacted>
Cc: Ferruh Yigit <redacted>
Cc: Andrew Rybchenko <redacted>
Cc: Gaetan Rivet <redacted>
--
v2 changes:

- Patch was not present in original series.
---
 lib/librte_ethdev/rte_flow.h | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)
diff --git a/lib/librte_ethdev/rte_flow.h b/lib/librte_ethdev/rte_flow.h
index c48ea8a51..891be1557 100644
--- a/lib/librte_ethdev/rte_flow.h
+++ b/lib/librte_ethdev/rte_flow.h
@@ -2332,6 +2332,7 @@ rte_flow_error_set(struct rte_flow_error *error,
 		   const char *message);
 
 /**
+ * @deprecated
  * @see rte_flow_copy()
  */
 struct rte_flow_desc {
@@ -2343,10 +2344,13 @@ struct rte_flow_desc {
 };
 
 /**
+ * @deprecated
  * Copy an rte_flow rule description.
  *
  * This interface is kept for compatibility with older applications but is
- * implemented as a wrapper to rte_flow_conv().
+ * implemented as a wrapper to rte_flow_conv(). It is deprecated due to its
+ * lack of flexibility and reliance on a type unusable with C++ programs
+ * (struct rte_flow_desc).
  *
  * @param[in] fd
  *   Flow rule description.
@@ -2365,6 +2369,7 @@ struct rte_flow_desc {
  *   If len is lower than the size of the flow, the number of bytes that would
  *   have been written to desc had it been sufficient. Nothing is written.
  */
+__rte_deprecated
 size_t
 rte_flow_copy(struct rte_flow_desc *fd, size_t len,
 	      const struct rte_flow_attr *attr,
-- 
2.11.0
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help