Re: [PATCH] net/mlx4: Avoid stripping the glue library
From: Luca Boccassi <hidden>
Date: 2018-07-31 13:30:45
On Tue, 2018-07-31 at 15:15 +0200, Timothy Redaelli wrote:
quoted hunk ↗ jump to hunk
Stripping binaries at build time is usually a bad thing since it makes impossible to generate (split) debug symbols and this can lead to a more difficult debugging. CC: Adrien Mazarguil <redacted> Fixes: 27cea11686ff ("net/mlx4: spawn rdma-core dependency plug-in") Signed-off-by: Timothy Redaelli <redacted> --- drivers/net/mlx4/Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)diff --git a/drivers/net/mlx4/Makefile b/drivers/net/mlx4/Makefile index 63bc00337..92e932250 100644 --- a/drivers/net/mlx4/Makefile +++ b/drivers/net/mlx4/Makefile@@ -115,7 +115,7 @@ endif$(LIB_GLUE): mlx4_glue.o $Q $(LD) $(GLUE_LDFLAGS) $(EXTRA_LDFLAGS) \ -Wl,-h,$(LIB_GLUE) \ - -s -shared -o $@ $< -libverbs -lmlx4 + -shared -o $@ $< -libverbs -lmlx4 mlx4_glue.o: mlx4_autoconf.h
Acked-by: Luca Boccassi <redacted> Automated tools to generate separate packages with debug symbols (the standard at least in Debian and derivatives distros) break if a library is stripped, and it's very hard to notice as well as it's not an error per se. -- Kind regards, Luca Boccassi