Re: [PATCH v11 07/25] eal: introduce device class abstraction
From: Thomas Monjalon <hidden>
Date: 2018-07-14 14:54:11
12/07/2018 09:41, Gaëtan Rivet:
On Thu, Jul 12, 2018 at 12:19:09PM +0530, Shreyansh Jain wrote:quoted
Any reason you don't want the rte_class_find and rte_class_find_by_name as exposed APIs? There is no experimental tag on these APIs either.No actually I just overlooked that part! Thanks for catching this, I think it should be exposed and tagged experimental.
Fixup below:
--- a/lib/librte_eal/common/eal_common_class.c
+++ b/lib/librte_eal/common/eal_common_class.c@@ -29,6 +29,7 @@ rte_class_unregister(struct rte_class *class) RTE_LOG(DEBUG, EAL, "Unregistered [%s] device class.\n", class->name); } +__rte_experimental struct rte_class * rte_class_find(const struct rte_class *start, rte_class_cmp_t cmp, const void *data)
@@ -55,6 +56,7 @@ cmp_class_name(const struct rte_class *class, const void *_name) return strcmp(class->name, name); } +__rte_experimental struct rte_class * rte_class_find_by_name(const char *name) { --- a/lib/librte_eal/common/include/rte_class.h +++ b/lib/librte_eal/common/include/rte_class.h
@@ -76,6 +76,7 @@ typedef int (*rte_class_cmp_t)(const struct rte_class *cls, const void *data); * @return * A pointer to a rte_class structure or NULL in case no class matches */ +__rte_experimental struct rte_class * rte_class_find(const struct rte_class *start, rte_class_cmp_t cmp, const void *data);
@@ -83,6 +84,7 @@ rte_class_find(const struct rte_class *start, rte_class_cmp_t cmp, /** * Find the registered class for a given name. */ +__rte_experimental struct rte_class * rte_class_find_by_name(const char *name); --- a/lib/librte_eal/rte_eal_version.map +++ b/lib/librte_eal/rte_eal_version.map
@@ -254,6 +254,8 @@ DPDK_18.08 { EXPERIMENTAL { global: + rte_class_find; + rte_class_find_by_name; rte_class_register; rte_class_unregister; rte_ctrl_thread_create;