Thread (14 messages) 14 messages, 4 authors, 2018-07-30

Re: [PATCH v2] vfio: fix workaround of BAR0 mapping

From: Burakov, Anatoly <hidden>
Date: 2018-07-12 09:11:07

On 12-Jul-18 4:08 AM, Takeshi Yoshimura wrote:
The workaround of BAR0 mapping does not work if BAR0 area is smaller
than page size (64KB in ppc). In addition, we no longer need the
workaround in recent Linux because VFIO allows MSIX mapping (*).
This fix is just to skip the workaround if BAR0 is smarller than a page.

(*): "vfio-pci: Allow mapping MSIX BAR",
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/
commit/id=a32295c612c57990d17fb0f41e7134394b2f35f6

Fixes: 90a1633b2347 ("eal/linux: allow to map BARs with MSI-X tables")

Signed-off-by: Takeshi Yoshimura <redacted>
---
Minimum support kernel version in DPDK is 3.2, we cannot rely on 
functionality provided by the recent kernel versions.

It would be better if you modified the check at line 350 instead (or 
added a new check, specifically testing for whether BAR size is less 
than page size).

-- 
Thanks,
Anatoly
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help