Thread (3 messages) 3 messages, 2 authors, 2018-07-11

Re: [PATCH v2] net/e1000: Support mtu set for igbvf.

From: Lu, Wenzhuo <hidden>
Date: 2018-07-10 01:03:38

Hi Ian,

quoted hunk ↗ jump to hunk
-----Original Message-----
From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Ian Stokes
Sent: Friday, June 29, 2018 9:51 PM
To: dev@dpdk.org
Cc: Stokes, Ian <redacted>; stable@dpdk.org
Subject: [dpdk-dev] [PATCH v2] net/e1000: Support mtu set for igbvf.

This patch enables setting the MTU of an igbvf device by re-using the
eth_igb_mtu_set() in igbvf_eth_dev_ops.

Cc: stable@dpdk.org

Signed-off-by: Ian Stokes <redacted>
---
 drivers/net/e1000/igb_ethdev.c | 1 +
 1 file changed, 1 insertion(+)
diff --git a/drivers/net/e1000/igb_ethdev.c b/drivers/net/e1000/igb_ethdev.c
index edc7be3..650e831 100644
--- a/drivers/net/e1000/igb_ethdev.c
+++ b/drivers/net/e1000/igb_ethdev.c
@@ -442,6 +442,7 @@ static const struct eth_dev_ops igbvf_eth_dev_ops =
{
 	.txq_info_get         = igb_txq_info_get,
 	.mac_addr_set         = igbvf_default_mac_addr_set,
 	.get_reg              = igbvf_get_regs,
+	.mtu_set              = eth_igb_mtu_set,
I think "eth_igb_mtu_set" is PF specific function that cannot be used on VF. As it touches PF specific registers.
Looks like MTU setting even not supported by igb VF.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help