Hi Sunil,

On 27-06-2018 11:50, Sunil Kumar Kori wrote:

External Email

Regards
Sunil Kumar

quoted

-----Original Message-----
From: Anoob Joseph [mailto:anoob.joseph@caviumnetworks.com]
Sent: Friday, June 8, 2018 10:54 PM
To: Bruce Richardson <redacted>; Jerin Jacob
[off-list ref]; Pablo de Lara
[off-list ref]
Cc: Anoob Joseph <redacted>; Hemant Agrawal
[off-list ref]; Narayana Prasad
[off-list ref]; Nikhil Rao
[off-list ref]; Pavan Nikhilesh
[off-list ref]; Sunil Kumar Kori
[off-list ref]; dev@dpdk.org
Subject: [PATCH 01/20] eventdev: add files for eventmode helper

Signed-off-by: Anoob Joseph <redacted>
---
  lib/librte_eventdev/Makefile                        | 2 ++
  lib/librte_eventdev/rte_eventmode_helper.c          | 7 +++++++
  lib/librte_eventdev/rte_eventmode_helper.h          | 6 ++++++
  lib/librte_eventdev/rte_eventmode_helper_internal.h | 6 ++++++
  4 files changed, 21 insertions(+)
  create mode 100644 lib/librte_eventdev/rte_eventmode_helper.c
  create mode 100644 lib/librte_eventdev/rte_eventmode_helper.h
  create mode 100644 lib/librte_eventdev/rte_eventmode_helper_internal.h

Having a separate helper library to configure eventdev may be a overhead to the application
as application needs to understand main DPDK API as well as helper routines.
It can be kept in application as a separate file.

For one application we could add a new file, but if we are to enable 
event mode with multiple applications, wouldn't this be duplication of 
lot of code? Considering that I haven't added the required parsing 
routines, the code additions in one application to make it eventdriven 
would be huge.

I do agree that making this as a library poses its own challenges, but 
do you have something better in mind? Another option we can think of is 
making all these changes part of some common headers and then each 
application can include and start using these functions. I'm fine with 
any approach, but we need to consider making at-least l3fwd & 
ipsec-secgw also event driven.

Thanks,
Anoob