-----Original Message-----
From: Gujjar, Abhinandan S
Sent: Wednesday, June 13, 2018 11:01 AM
To: De Lara Guarch, Pablo <redacted>; Doherty, Declan
[off-list ref]
Cc: dev@dpdk.org; stable@dpdk.org
Subject: RE: [PATCH] cryptodev: fix ABI breakage

quoted

-----Original Message-----
From: De Lara Guarch, Pablo
Sent: Wednesday, June 13, 2018 3:07 PM
To: Doherty, Declan <redacted>; Gujjar, Abhinandan S
[off-list ref]
Cc: dev@dpdk.org; De Lara Guarch, Pablo
[off-list ref]; stable@dpdk.org
Subject: [PATCH] cryptodev: fix ABI breakage

In 17.08, the crypto operation was restructured, and some reserved
bytes (5) were added  to have the mempool pointer aligned to 64 bits,
since the structure is expected to be aligned to 64 bits, allowing
future additions with no ABI breakage needed.

In 18.05, a new 2-byte field was added, so the reserved bytes were reduced to

3.

quoted

However, this field was added after the first 3 bytes of the
structure, causing it to be placed in an offset of 4 bytes, and
therefore, forcing the mempool pointer to be placed after 16 bytes,
instead of a 8 bytes, causing unintentionally the ABI breakage.

This commit fixes the breakage, by swapping the reserved bytes and the
private_data_offset field, so the latter is aligned to 2 bytes and the
offset of the mempool pointer returns to its original offset,
8 bytes.

Fixes: 54c836846603 ("cryptodev: set private data for session-less
mode")
Cc: stable@dpdk.org

Reported-by: Konstantin Ananyev <redacted>
Signed-off-by: Pablo de Lara <redacted>

...

Acked-by: Abhinandan Gujjar <redacted>

quoted

2.17.0

Applied to dpdk-next-crypto.

Pablo