Re: [PATCH] crypto/zuc: add dynamic logging to zuc

Hi Agalya,

-----Original Message-----
From: Babu Radhakrishnan, AgalyaX
Sent: Friday, June 22, 2018 10:28 AM
To: dev@dpdk.org
Cc: De Lara Guarch, Pablo <redacted>; Pattan, Reshma
[off-list ref]; Babu Radhakrishnan, AgalyaX
[off-list ref]
Subject: [PATCH] crypto/zuc: add dynamic logging to zuc

    1.added new logtype for zuc driver.
    2.registered new logtype.
    3.ZUC_LOG_ERR and CDEV_LOG_ERR are
    replaced with new logtype name ZUC_PMD_LOG

Signed-off-by: Agalya Babu RadhaKrishnan
[off-list ref]
Reviewed-by: Reshma Pattan <redacted>

Could you make the following changes?

- Change the macro to ZUC_LOG, to make it shorter.
- Change title to: crypto/zuc: add dynamic logging
- Is your surname RadhaKrishnan all together or with a space?
Because there is a mismatch between the author and the Signed-off-by line.
- Remove unused "CONFIG_RTE_LIBRTE_PMD_ZUC_DEBUG=n"
from config file.
- Set log level of the new type to INFO (see isal_compress_pmd.c)

Thanks,
Pablo