Re: [PATCH] crypto/kasumi: add dynamic logging to kasumi
From: De Lara Guarch, Pablo <hidden>
Date: 2018-06-27 15:38:09
Hi Naga, Two last comments below.
-----Original Message----- From: Somarowthu, Naga SureshX Sent: Monday, June 25, 2018 6:23 AM To: dev@dpdk.org Cc: De Lara Guarch, Pablo <redacted>; Pattan, Reshma [off-list ref]; Somarowthu, Naga SureshX [off-list ref] Subject: [PATCH] crypto/kasumi: add dynamic logging to kasumi 1.added new logtype for kasumi driver. 2.registered new logtype. 3.KASUMI_LOG_ERR and CDEV_LOG_ERR are replaced with new logtype name KASUMI_PMD_LOG. Signed-off-by: Naga Suresh Somarowthu [off-list ref] Reviewed-by: Reshma Pattan <redacted> ---
...
if (cipher_xform) {
/* Only KASUMI F8 supported */
if (cipher_xform->cipher.algo !=
RTE_CRYPTO_CIPHER_KASUMI_F8)
+ KASUMI_PMD_LOG(ERR, "Unsupported cipher
algorithm ");
return -ENOTSUP;Missing braces, as there are two lines inside the if statement.
quoted hunk ↗ jump to hunk
sess->cipher_iv_offset = cipher_xform->cipher.iv.offset; if (cipher_xform->cipher.iv.length != KASUMI_IV_LENGTH) { - KASUMI_LOG_ERR("Wrong IV length"); + KASUMI_PMD_LOG(ERR, "Wrong IV length"); return -EINVAL; }@@ -102,10 +103,11 @@ kasumi_set_session_parameters(structkasumi_session *sess, if (auth_xform) { /* Only KASUMI F9 supported */ if (auth_xform->auth.algo != RTE_CRYPTO_AUTH_KASUMI_F9) + KASUMI_PMD_LOG(ERR, "Unsupported authentication"); return -ENOTSUP;
Missing braces, as there are two lines inside the if statement.
if (auth_xform->auth.digest_length !=