Re: [PATCH] net/virtio-user: add unsupported features mask

On 06/25/2018 03:10 PM, Marvin Liu wrote:

This patch introduces unsupported features mask for virtio-user device.
For virtio-user server mode, when reconnecting virtio-user will
retrieve vhost devcie features as base and then unmask unsupported

s/devcie/device/

features.

I am not sure to understand why you are doing it like this.

Shouldn't you just:
  1. Don't advertise features you don't want to support
  2. In server mode, save the negotiated features, and re-use it when
     reconnect happens?

Also, I find "unmask" a bit misleading, why not something like "unsupp"
or "unsupported"?

Thanks,
Maxime