Re: [PATCH 2/3] app/testpmd: enable UDP GSO in the checksum forwarding engine
From: Iremonger, Bernard <hidden>
Date: 2018-06-14 14:44:16
Hi Jiayu,
quoted hunk ↗ jump to hunk
-----Original Message----- From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Jiayu Hu Sent: Tuesday, May 29, 2018 8:41 AM To: dev@dpdk.org Cc: Ananyev, Konstantin <redacted>; Hu, Jiayu [off-list ref] Subject: [dpdk-dev] [PATCH 2/3] app/testpmd: enable UDP GSO in the checksum forwarding engine This patch enables GSO for UDP/IPv4 packets. Oversized UDP/IPv4 packets transmitted over a GSO-enabled port will undergo segmentation. Signed-off-by: Jiayu Hu <redacted> --- app/test-pmd/cmdline.c | 5 +++-- app/test-pmd/csumonly.c | 2 ++ app/test-pmd/testpmd.c | 2 +- 3 files changed, 6 insertions(+), 3 deletions(-)diff --git a/app/test-pmd/cmdline.c b/app/test-pmd/cmdline.c index27e2aa8..4239e91 100644--- a/app/test-pmd/cmdline.c +++ b/app/test-pmd/cmdline.c@@ -4792,8 +4792,9 @@ cmd_gso_show_parsed(void *parsed_result, if (gso_ports[res->cmd_pid].enable) { printf("Max GSO'd packet size: %uB\n" "Supported GSO types: TCP/IPv4, " - "VxLAN with inner TCP/IPv4 packet, " - "GRE with inner TCP/IPv4 packet\n", + "UDP/IPv4, VxLAN with inner " + "TCP/IPv4 packet, GRE with inner " + "TCP/IPv4 packet\n",
This change is giving 3 checkpatch.pl warnings and should be refactored
quoted hunk ↗ jump to hunk
gso_max_segment_size); } else printf("GSO is not enabled on Port %u\n", res-quoted
cmd_pid); diff --git a/app/test-pmd/csumonly.c b/app/test-pmd/csumonly.c index 0bb88cf..4948292 100644--- a/app/test-pmd/csumonly.c +++ b/app/test-pmd/csumonly.c@@ -411,6 +411,8 @@ process_inner_cksums(void *l3_hdr, const structtestpmd_offload_info *info, info->ethertype); } } + if (info->gso_enable) + ol_flags |= PKT_TX_UDP_SEG; } else if (info->l4_proto == IPPROTO_TCP) { tcp_hdr = (struct tcp_hdr *)((char *)l3_hdr + info->l3_len); tcp_hdr->cksum = 0;diff --git a/app/test-pmd/testpmd.c b/app/test-pmd/testpmd.c index35cf266..b5766ff 100644--- a/app/test-pmd/testpmd.c +++ b/app/test-pmd/testpmd.c@@ -777,7 +777,7 @@ init_config(void) init_port_config(); gso_types = DEV_TX_OFFLOAD_TCP_TSO |DEV_TX_OFFLOAD_VXLAN_TNL_TSO | - DEV_TX_OFFLOAD_GRE_TNL_TSO; + DEV_TX_OFFLOAD_GRE_TNL_TSO | DEV_TX_OFFLOAD_UDP_TSO; /* * Records which Mbuf pool to use by each logical core, if needed. */ -- 2.7.4
./devtools/check-git-log.sh -1
Headline too long:
app/testpmd: enable UDP GSO in the checksum forwarding engine
Should the dpdk/doc/guides/testpmd_ap_ug/testpmd_funcs.rst file be updated?
Regards,
Bernard