Re: [PATCH 04/17] net/virtio: add packed virtqueue helpers
From: Tiwei Bie <hidden>
Date: 2018-03-19 08:25:05
On Fri, Mar 16, 2018 at 04:21:07PM +0100, Jens Freimann wrote:
Add helper functions to set/clear and check descriptor flags. Signed-off-by: Jens Freimann <redacted> ---
[...]
quoted hunk ↗ jump to hunk
--- a/drivers/net/virtio/virtio_ring.h +++ b/drivers/net/virtio/virtio_ring.h@@ -74,12 +74,45 @@ struct vring_desc_packed { struct vring { unsigned int num; + unsigned int avail_wrap_counter; struct vring_desc *desc; struct vring_avail *avail; struct vring_used *used; struct vring_desc_packed *desc_packed;
Maybe it's better to use anonymous union.
};
[...]
quoted hunk ↗ jump to hunk
diff --git a/drivers/net/virtio/virtqueue.c b/drivers/net/virtio/virtqueue.c index a7d0a9c..6806056 100644 --- a/drivers/net/virtio/virtqueue.c +++ b/drivers/net/virtio/virtqueue.c@@ -65,6 +65,9 @@ struct rte_mbuf *
Please make sure the diff contains function name.
uint16_t used_idx, desc_idx; uint16_t nb_used, i; + if (vtpci_packed_queue(vq->hw)) + return;
I guess packed-ring also needs to support virtqueue_rxvq_flush(). Thanks
+
nb_used = VIRTQUEUE_NUSED(vq);
for (i = 0; i < nb_used; i++) {
--
1.8.3.1