Re: [PATCH] eal/ppc: fix rte_smp_mb for a compilation error with else clause
From: Chao Zhu <hidden>
Date: 2018-02-28 09:56:21
-----Original Message----- From: Gowrishankar [mailto:gowrishankar.m@linux.vnet.ibm.com] Sent: 2018年2月27日 23:14 To: dev@dpdk.org Cc: Chao Zhu <redacted>; stable@dpdk.org; thomas@monjalon.net; Gowrishankar Muthukrishnan [off-list ref] Subject: [PATCH] eal/ppc: fix rte_smp_mb for a compilation error with else clause From: Gowrishankar Muthukrishnan <redacted> This patch fixes the compilation problem with rte_smp_mb, when there is
else
quoted hunk ↗ jump to hunk
clause following it, as in test_barrier.c. Fixes: 05c3fd7110 ("eal/ppc: atomic operations for IBM Power") Cc: stable@dpdk.org Signed-off-by: Gowrishankar Muthukrishnan [off-list ref] --- lib/librte_eal/common/include/arch/ppc_64/rte_atomic.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)diff --git a/lib/librte_eal/common/include/arch/ppc_64/rte_atomic.hb/lib/librte_eal/common/include/arch/ppc_64/rte_atomic.h index 39fce7b..1821774 100644--- a/lib/librte_eal/common/include/arch/ppc_64/rte_atomic.h +++ b/lib/librte_eal/common/include/arch/ppc_64/rte_atomic.h@@ -55,7 +55,7 @@ * Guarantees that the LOAD and STORE operations generated before the * barrier occur before the LOAD and STORE operations generated after. */ -#define rte_mb() {asm volatile("sync" : : : "memory"); } +#define rte_mb() asm volatile("sync" : : : "memory") /** * Write memory barrier. --1.9.1
Acked-by: Chao Zhu <redacted>