Thread (5 messages) flat view 5 messages, 3 authors, 2018-02-19

Re: [PATCH 1/2] eal: add API to align integer to previous power of 2

From: Wiles, Keith <hidden>
Date: 2018-02-19 13:55:35

On Feb 19, 2018, at 12:03 AM, Matan Azrad [off-list ref] wrote:

quoted
Is this the type of API that needs to be marked experimental,
I think it is relevant to any exposed API(not only for internal libraries).
quoted
we should be able to prove these functions, correct?
Don't we need to prove any function in DPDK?
What is your point?

My point is this is a inline function and can not be placed in the .map file as a external API. These simple type of APIs are easy to prove and making them experimental seems to just cause an extra step. If the functions are not required that is a different problem or if the API is really only ever used by a single function or module of files then it should be moved to the module/file and made locate to the module/file.
quoted
quoted
Matan
Regards,
Keith
Regards,
Keith
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help