Thread (5 messages) 5 messages, 3 authors, 2018-02-05

Re: [PATCH] mk: add debug target

From: Olivier Matz <hidden>
Date: 2018-02-05 09:23:07

On Fri, Feb 02, 2018 at 10:07:31AM +0100, Thomas Monjalon wrote:
01/02/2018 18:04, Ferruh Yigit:
quoted
On 1/30/2018 11:40 PM, Thomas Monjalon wrote:
quoted
16/12/2017 01:13, Ferruh Yigit:
quoted
Add "debug" target to build library with debug symbols and optimization
disabled.

This is shortcut for exiting method to compile with
EXTRA_CFLAGS="-O0 -g3"

Signed-off-by: Ferruh Yigit <redacted>
---
+	debug            build library with debug symbols
[...]
quoted
+.PHONY: debug
+debug:
+	$(Q)$(MAKE) EXTRA_CFLAGS="-O0 -g3"
This target will override any EXTRA_CFLAGS,
so we cannot build in debug mode with more extra cflags this way.
How about EXTRA_CFLAGS+="-O0 -g3"
which is not override EXTRA_CFLAGS but merge them, can be ok?
I am not sure it works. Have you tested?
Instead of adding a new target, what about, having:

  make DEBUG=1

The DEBUG variable could be used by the rte.*.mk to set the specific
flags, before the EXTRA_* flags.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help