Thread (17 messages) 17 messages, 6 authors, 2018-02-03

Re: [PATCH v3] net/mlx4: fix dev rmv not detected after port stop

From: Shahaf Shuler <hidden>
Date: 2018-01-29 10:54:16

Mordechay Haimovsky, Monday, January 29, 2018 10:35 AM:
In failsafe device start can be called for ports/devices that had been plugged
out.
The mlx4 PMD detects device removal by listening to the device RMV events,
when the mlx4 port is being stopped, the PMD no longer listens to these
events causing the PMD to stop detecting device removals.
This patch fixes this issue by moving installation of the interrupt handler to
device configuration, and toggle only the Rx-queue interrupts on start/stop.

Fixes: a6e8b01c3c26 ("net/mlx4: compact interrupt functions")
Cc: stable@dpdk.org

Signed-off-by: Moti Haimovsky <redacted>
---
V3:
Modifications according to review inputs from Shahaf Shuler
See: 1516357009-15463-1-git-send-email-motih@mellanox.com

V2:
Fixed commit message.
---

 drivers/net/mlx4/mlx4.c      | 10 ++++++++--
 drivers/net/mlx4/mlx4.h      |  2 ++
 drivers/net/mlx4/mlx4_intr.c | 41
++++++++++++++++++++++++++++++++++++++---
 3 files changed, 48 insertions(+), 5 deletions(-)
Acked-by: Shahaf Shuler <redacted> 

Adrien - let me know if you see issues with this patch, I want to include it on RC2.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help