Hi Ravi,

-----Original Message-----
From: Kumar, Ravi1 [mailto:Ravi1.Kumar@amd.com]
Sent: Wednesday, January 17, 2018 9:09 AM
To: De Lara Guarch, Pablo <redacted>;
dev@dpdk.org
Cc: Shippen, Greg <redacted>
Subject: RE: [PATCH v3 01/19] crypto/ccp: add AMD ccp skeleton PMD

quoted

Hi Ravi,

quoted

-----Original Message-----
From: Kumar, Ravi1 [mailto:Ravi1.Kumar@amd.com]
Sent: Thursday, January 11, 2018 6:37 AM
To: De Lara Guarch, Pablo <redacted>;
dev@dpdk.org
Cc: Shippen, Greg <redacted>
Subject: RE: [PATCH v3 01/19] crypto/ccp: add AMD ccp skeleton PMD

quoted

-----Original Message-----

quoted

From: Kumar, Ravi1 [mailto:Ravi1.Kumar@amd.com]
Sent: Wednesday, January 10, 2018 10:30 AM
To: De Lara Guarch, Pablo <redacted>;
dev@dpdk.org
Cc: Shippen, Greg <redacted>
Subject: RE: [PATCH v3 01/19] crypto/ccp: add AMD ccp skeleton

PMD

quoted

quoted

quoted

quoted

quoted

Hi Ravi,

quoted

-----Original Message-----
From: Ravi Kumar [mailto:Ravi1.kumar@amd.com]
Sent: Wednesday, January 10, 2018 9:43 AM
To: dev@dpdk.org
Cc: De Lara Guarch, Pablo <redacted>
Subject: [PATCH v3 01/19] crypto/ccp: add AMD ccp skeleton

PMD

quoted

quoted

quoted

quoted

quoted

quoted

Signed-off-by: Ravi Kumar <redacted>
---

...

quoted

--- /dev/null
+++ b/drivers/crypto/ccp/Makefile

@@ -0,0 +1,55 @@
+#
+#   Copyright(c) 2018 Advanced Micro Devices, Inc.
+#   All rights reserved.
+#

As Hemant commented, you need to change this full license with
SPDX

tags:

quoted

http://dpdk.org/ml/archives/dev/2018-January/085510.html

Could you submit a v4 with these changes today?

Thanks,
Pablo

Hi Pablo,

Our legal team is still working on the license. We want to get the
code reviewed in parallel.
I will give you and update later if we can upload the v4 patch
with SPDX tags today.

Ok, I have looked at the overall patchset and it looks ok to me.
The only thing that I would change is the title of patch 7/19:
I would change it to "crypto/ccp: support sessionless operations".

Regards,
Pablo

Hi Pablo,

Thanks for going through our code. Good to know the code is fine.

The new changes in licensing policy has introduced some delays as we
work through the implications and get agreement from the third party.

We are working on it and will upload the v4 with SPDX license tags as
soon as possible.

Any news? RC1 will be out on Friday, and the subtree should be close

tomorrow evening, and there will not be more features added after this
point.

quoted

Thanks,
Pablo

Hi Pablo,

We are still in the process of getting the sign off on the new SPDX license
tags from the third party. We expect an answer from them by the end of
the week at the earliest.

I will get back to you as soon as I have some update.

Any update? This could still be merged in RC2, but no later than that.

Thanks,
Pablo

Regards,
Ravi

quoted

quoted

Regards,
Ravi

quoted

quoted

Regards,
Ravi