Re: [PATCH v1 1/5] rawdev: introduce raw device library support
From: Thomas Monjalon <hidden>
Date: 2018-01-14 22:43:05
Hi, 02/01/2018 13:57, Shreyansh Jain:
A device is DPDK has a flavor to it - ethernet, crypto, event etc.
I don't understand this sentence. I guess it can be completely removed.
A rawdevice represents a generic device map-able to a device flavour not being currently handled out-of-the-box by DPDK framework. A device which can be scanned on an installed bus (pci, fslmc, ...) or instantiated through devargs, can be interfaced using standardized APIs just like other standardized devices. This library introduces an API set which can be plugged on the northbound side to the application layer, and on the southbound side to the driver layer. The APIs of rawdev library exposes some generic operations which can enable configuration and I/O with the raw devices.
You should explain that it uses some opaque pointers.
Signed-off-by: Shreyansh Jain <redacted> --- lib/librte_rawdev/Makefile | 27 ++ lib/librte_rawdev/rte_rawdev.c | 540 ++++++++++++++++++++++++++++ lib/librte_rawdev/rte_rawdev.h | 586 ++++++++++++++++++++++++++++++ lib/librte_rawdev/rte_rawdev_pmd.h | 588 +++++++++++++++++++++++++++++++ lib/librte_rawdev/rte_rawdev_version.map | 33 ++
Please add an entry in MAINTAINERS with EXPERIMENTAL tag. Sorry, no time to review the code myself. Thanks