On 1/11/2018 2:07 AM, Lu, Wenzhuo wrote:

Hi Stephen,

quoted

-----Original Message-----
From: Stephen Hemminger [mailto:stephen@networkplumber.org]
Sent: Thursday, January 11, 2018 1:15 AM
To: Lu, Wenzhuo <redacted>
Cc: dev@dpdk.org; Wu, Jingjing <redacted>
Subject: Re: [dpdk-dev] [PATCH v6 02/14] net/avf: initialization of avf PMD

On Wed, 10 Jan 2018 14:15:49 +0800
Wenzhuo Lu [off-list ref] wrote:

quoted

+
+#define AVF_MAX_NUM_QUEUES       16
+/* Vlan table size */
+#define AVF_VLAN_TB_SIZE               (4096 / (CHAR_BIT * sizeof(uint32_t)))

You could use ETHER_MAX_VLAN_ID (which is 4095).
Also it is most efficient if bit tables use unsigned long to access.

Thanks for the suggestion.
I found this macro is useless. I'd like just removing it.

Hi Ferruh,
As this patch set is accepted to next-net, I can sent a fixes patch for this change. Is it OK? Would you like helping merge the fixes to the original patch? Thanks.

Hi Wenzhuo,

That is OK, I can squash fixes on top original set in next-net.