Thread (14 messages) 14 messages, 4 authors, 2018-01-10

Re: [PATCH v1] app/testpmd: support command echo in CLI batch loading

From: Xueming(Steven) Li <hidden>
Date: 2018-01-10 08:51:33

-----Original Message-----
From: Lu, Wenzhuo [mailto:wenzhuo.lu@intel.com]
Sent: Wednesday, January 10, 2018 4:36 PM
To: Xueming(Steven) Li <redacted>
Cc: Wu, Jingjing <redacted>; dev@dpdk.org; Olivier MATZ
[off-list ref]; Burakov, Anatoly [off-list ref]
Subject: RE: [dpdk-dev] [PATCH v1] app/testpmd: support command echo in
CLI batch loading

Hi Xueming,
quoted
-----Original Message-----
From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Xueming Li
Sent: Tuesday, December 26, 2017 10:26 PM
Cc: Xueming Li <redacted>; Wu, Jingjing
[off-list ref]; dev@dpdk.org; Olivier MATZ
[off-list ref]; Burakov, Anatoly [off-list ref]
Subject: [dpdk-dev] [PATCH v1] app/testpmd: support command echo in
CLI batch loading

Use first bit of verbose_level to enable CLI echo of batch loading.
After this patch, the first bit of verbose_level is ambiguous. It can
still enable/disable the log print.
Is it by design?
You are correct, there are some code in testpmd simply testing verbose>0.
How about changing all the test to: verbose & 1? I have another patchset
using other bits of verbose...
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help