On 12/22/2017 8:21 PM, Wiles, Keith wrote:

quoted

On Dec 22, 2017, at 8:17 AM, Thomas Monjalon [off-list ref] wrote:

22/12/2017 14:59, Wiles, Keith:

quoted

quoted

On Dec 22, 2017, at 5:38 AM, Thomas Monjalon [off-list ref] wrote:

22/12/2017 11:04, Hemant Agrawal:

quoted

On 12/22/2017 2:13 PM, Thomas Monjalon wrote:

quoted

These modules are Linux modules, so they should be in the linuxapp dir.

This is a cleaner separation w.r.t userspace/kernel space code.
*kern* is a better placefolder for LKMs.

I prefer "kernel" name.

The name should be related to Linux in some way, like linux_kern or linux_kernel or linux_modules (this is the one I prefer) this way it make it clear which OS they are designed for.

If such top-level directory is created, the BSD modules must be moved there too.
That's why "kernel/" or "kernel/linux/" is appropriate.

OK seems reasonable, what about kernel/{freebsd,Linux, …}/modules/(module-name e.g. kni, igb_uio, nic_uio, …)

Kernel is misleading IMO, but I can live with it as long as we break down the different kernel related items. This is why I add modules in the path, as we could have other OSes like Windows with items that are not modules or VMs or containers…

I can live with kernel/{freebsd, linux, …}/{igb_uio, kni, nic_uio, ..}  but I would like to make sure it does not change in the future with adding windows.

Your suggestion seems reasonable.

I am not sure about windows.
May be some working on DPDK-on-windows can comment

quoted

quoted

quoted

quoted

Also eal is not getting overloaded.

linuxapp is part of librte_eal.  KNI is not related to EAL, but still
the kni kernel code is added to librte_eal under linuxapp.

Yes it makes sense.

More opinions/votes?

quoted

quoted

There are also some kernel modules in the bsdapp directory.

We can move them as well.

Regards,
Keith