Thread (105 messages) 105 messages, 6 authors, 2017-10-09

Re: [PATCH v5 4/9] examples/vm_power_mgr: add scale to medium freq fn

From: santosh <hidden>
Date: 2017-10-05 09:07:39

Hi David,


On Thursday 05 October 2017 02:17 PM, Hunt, David wrote:
Hi Santosh,


On 4/10/2017 5:04 PM, santosh wrote:
quoted
Hi David,


On Wednesday 04 October 2017 08:55 PM, David Hunt wrote:
quoted
Signed-off-by: Nemanja Marjanovic <redacted>
Signed-off-by: Rory Sexton <redacted>
Signed-off-by: David Hunt <redacted>
---
  examples/vm_power_manager/power_manager.c | 15 +++++++++++++++
  examples/vm_power_manager/power_manager.h | 13 +++++++++++++
  2 files changed, 28 insertions(+)
diff --git a/examples/vm_power_manager/power_manager.c b/examples/vm_power_manager/power_manager.c
index 80705f9..c021c1d 100644
--- a/examples/vm_power_manager/power_manager.c
+++ b/examples/vm_power_manager/power_manager.c
@@ -286,3 +286,18 @@ power_manager_disable_turbo_core(unsigned int core_num)
      POWER_SCALE_CORE(disable_turbo, core_num, ret);
      return ret;
  }
+
+int
+power_manager_scale_core_med(unsigned int core_num)
+{
+    int ret = 0;
+
+    if (core_num >= POWER_MGR_MAX_CPUS)
+        return -1;
+    if (!(global_enabled_cpus & (1ULL << core_num)))
+        return -1;
+    rte_spinlock_lock(&global_core_freq_info[core_num].power_sl);
+    ret = rte_power_set_freq(core_num, 5);
nits:
what is 5? also should be enum or macro.

Thanks.
This probably shouldn't be hard-coded. The intention is to select a middle frequency. I can add a helper function to get the value
that is halfway between min and max, and use that instead.
I'm ok with your proposition.
Thanks.
Thanks,
Dave.

Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help