Re: [PATCH v3] cryptodev: allocate driver structure statically

-----Original Message-----
From: Rybalchenko, Kirill
Sent: Monday, September 4, 2017 11:39 AM
To: De Lara Guarch, Pablo <redacted>; Doherty,
Declan [off-list ref]; Trahe, Fiona [off-list ref];
Jain, Deepak K [off-list ref]; Griffin, John
[off-list ref]; jerin.jacob@caviumnetworks.com;
akhil.goyal@nxp.com; hemant.agrawal@nxp.com
Cc: dev@dpdk.org
Subject: RE: [dpdk-dev] [PATCH v3] cryptodev: allocate driver structure
statically

quoted

-----Original Message-----
From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Pablo de Lara
Sent: Wednesday 16 August 2017 03:42
To: Doherty, Declan <redacted>; Trahe, Fiona
[off-list ref]; Jain, Deepak K [off-list ref];
Griffin, John [off-list ref];
jerin.jacob@caviumnetworks.com; akhil.goyal@nxp.com;
hemant.agrawal@nxp.com
Cc: dev@dpdk.org; De Lara Guarch, Pablo
[off-list ref]
Subject: [dpdk-dev] [PATCH v3] cryptodev: allocate driver structure
statically

When register a crypto driver, a cryptodev driver structure was being
allocated, using malloc.
Since this call may fail, it is safer to allocate this memory
statically in each PMD, so driver registration will never fail.

Coverity issue: 158645

Fixes: 7a364faef185 ("cryptodev: remove crypto device type
enumeration")

Signed-off-by: Pablo de Lara <redacted>
---

Changes in v3:

- Added documentation (removed deprecation notice and added API
Change)
- Modified title to something more explicit

Changes in v2:

- Allocate statically the cryptodev driver structure,
  instead of using malloc, that can potentially fail.

 doc/guides/rel_notes/deprecation.rst        |  6 ------
 doc/guides/rel_notes/release_17_11.rst      |  5 +++++
 drivers/crypto/aesni_gcm/aesni_gcm_pmd.c    |  5 ++++-
 drivers/crypto/aesni_mb/rte_aesni_mb_pmd.c  |  6 +++++-
 drivers/crypto/armv8/rte_armv8_pmd.c        |  9 ++++++---
 drivers/crypto/dpaa2_sec/dpaa2_sec_dpseci.c |  5 ++++-
 drivers/crypto/kasumi/rte_kasumi_pmd.c      |  5 ++++-
 drivers/crypto/null/null_crypto_pmd.c       |  5 ++++-
 drivers/crypto/openssl/rte_openssl_pmd.c    |  5 ++++-
 drivers/crypto/qat/rte_qat_cryptodev.c      |  7 +++++--
 drivers/crypto/scheduler/scheduler_pmd.c    |  5 ++++-
 drivers/crypto/snow3g/rte_snow3g_pmd.c      |  5 ++++-
 drivers/crypto/zuc/rte_zuc_pmd.c            |  5 ++++-
 lib/librte_cryptodev/rte_cryptodev.c        | 18 +++++------------
 lib/librte_cryptodev/rte_cryptodev.h        | 20 -------------------
 lib/librte_cryptodev/rte_cryptodev_pmd.h    | 30
+++++++++++++++++++++++++++++
 16 files changed, 88 insertions(+), 53 deletions(-)

Reviewed-by: Kirill Rybalchenko <redacted>

Applied to dpdk-next-crypto.

Pablo