Re: [PATCH 5/6] eal: remove xen dom0 support
From: Bruce Richardson <hidden>
Date: 2017-09-04 14:49:21
On Mon, Sep 04, 2017 at 03:43:02PM +0100, Bruce Richardson wrote:
On Wed, Aug 30, 2017 at 06:10:33PM +0000, Jianfeng Tan wrote:quoted
We remove xen-specific code in EAL, including the option --xen-dom0, memory initialization code, compiling dependency, etc. Besides, related documents are removed or updated. Signed-off-by: Jianfeng Tan <redacted> --- MAINTAINERS | 7 - config/common_base | 5 - doc/guides/index.rst | 1 - doc/guides/linux_gsg/build_sample_apps.rst | 5 +- doc/guides/linux_gsg/sys_reqs.rst | 53 -- doc/guides/prog_guide/source_org.rst | 1 - doc/guides/rel_notes/deprecation.rst | 3 - doc/guides/rel_notes/release_17_11.rst | 12 + doc/guides/testpmd_app_ug/run_app.rst | 4 - doc/guides/xen/img/dpdk_xen_pkt_switch.png | Bin 163842 -> 0 bytes doc/guides/xen/img/grant_refs.png | Bin 6405 -> 0 bytes doc/guides/xen/img/grant_table.png | Bin 96762 -> 0 bytes doc/guides/xen/index.rst | 38 - doc/guides/xen/pkt_switch.rst | 470 ------------- .../bsdapp/eal/include/exec-env/rte_dom0_common.h | 107 --- lib/librte_eal/common/eal_common_options.c | 3 - lib/librte_eal/common/eal_internal_cfg.h | 1 - lib/librte_eal/common/eal_options.h | 2 - lib/librte_eal/common/include/rte_memory.h | 66 -- lib/librte_eal/linuxapp/Makefile | 2 - lib/librte_eal/linuxapp/eal/Makefile | 5 +- lib/librte_eal/linuxapp/eal/eal.c | 24 - lib/librte_eal/linuxapp/eal/eal_memory.c | 56 -- lib/librte_eal/linuxapp/eal/eal_xen_memory.c | 381 ---------- .../eal/include/exec-env/rte_dom0_common.h | 108 --- lib/librte_eal/linuxapp/igb_uio/igb_uio.c | 54 -- lib/librte_eal/linuxapp/xen_dom0/Makefile | 53 -- lib/librte_eal/linuxapp/xen_dom0/compat.h | 15 - lib/librte_eal/linuxapp/xen_dom0/dom0_mm_dev.h | 107 --- lib/librte_eal/linuxapp/xen_dom0/dom0_mm_misc.c | 780 --------------------- pkg/dpdk.spec | 3 -The xen functions that were removed are still listed in the linux/bsd version.map files. Not an ABI versioning expert, but I believe they should be removed as they are no longer present.
Reading the contributors guide section on ABI, specifically http://dpdk.org/doc/guides/contributing/versioning.html#deprecating-an-entire-abi-version it seems like we should collapse down the versions to a single one following the function removal, and also increment the whole library so version. /Bruce