Re: [PATCH v4 4/7] mempool: get the mempool capability
From: Olivier MATZ <hidden>
Date: 2017-09-04 14:32:15
On Tue, Aug 15, 2017 at 11:37:40AM +0530, Santosh Shukla wrote:
quoted hunk ↗ jump to hunk
Allow mempool to advertise its capability. A handler been introduced called rte_mempool_ops_get_capabilities. - Upon ->get_capabilities call, mempool driver will advertise capability by updating to 'mp->flags'. Signed-off-by: Santosh Shukla <redacted> Signed-off-by: Jerin Jacob <redacted> --- lib/librte_mempool/rte_mempool.c | 5 +++++ lib/librte_mempool/rte_mempool.h | 20 ++++++++++++++++++++ lib/librte_mempool/rte_mempool_ops.c | 14 ++++++++++++++ lib/librte_mempool/rte_mempool_version.map | 7 +++++++ 4 files changed, 46 insertions(+)diff --git a/lib/librte_mempool/rte_mempool.c b/lib/librte_mempool/rte_mempool.c index f95c01c00..d518c53de 100644 --- a/lib/librte_mempool/rte_mempool.c +++ b/lib/librte_mempool/rte_mempool.c@@ -529,6 +529,11 @@ rte_mempool_populate_default(struct rte_mempool *mp) if (mp->nb_mem_chunks != 0) return -EEXIST; + /* Get mempool capability */ + ret = rte_mempool_ops_get_capabilities(mp); + if (ret) + RTE_LOG(DEBUG, MEMPOOL, "get_capability not supported for %s\n", mp->name); +
there is probably a checkpatch error here (80 cols)
+/** + * @internal wrapper for mempool_ops get_capabilities callback. + * + * @param mp + * Pointer to the memory pool. + * @return + * - 0: Success; Capability updated to mp->flags + * - <0: Error; code of capability function. + */ +int +rte_mempool_ops_get_capabilities(struct rte_mempool *mp); +
What does "Capability updated to mp->flags" mean?
Why not having instead:
int rte_mempool_ops_get_capabilities(struct rte_mempool *mp,
unsigned int *flags);
?