Re: [PATCH 03/16] nfp: add support for new pci id

On Thu, Aug 31, 2017 at 10:13 AM, Ferruh Yigit [off-list ref]
wrote:

On 8/31/2017 10:08 AM, Alejandro Lucero wrote:

quoted

On Mon, Aug 28, 2017 at 5:43 PM, Ferruh Yigit <ferruh.yigit@intel.com
<mailto:ferruh.yigit@intel.com>> wrote:

    On 8/24/2017 5:20 PM, Alejandro Lucero wrote:
    > A NFP PF PCI devices can have PCI ID 4000 or 6000.
    >
    > Signed-off-by: Alejandro Lucero <alejandro.lucero@netronome.com

<mailto:alejandro.lucero@netronome.com>>

quoted

    <...>

    > @@ -2682,6 +2682,10 @@ static int nfp_pf_pci_probe(struct

rte_pci_driver *pci_drv __rte_unused,

quoted

    >  static const struct rte_pci_id pci_id_nfp_pf_net_map[] = {
    >       {
    >               RTE_PCI_DEVICE(PCI_VENDOR_ID_NETRONOME,
    > +                            PCI_DEVICE_ID_NFP4000_PF_NIC)

    I have seen nfp documentation updated with this new device, and I
    believe it also worth updating release notes to mention new device
    support (doc/guides/rel_notes/release_17_11.rst)


Yes, I agree. I should add this as well.


    Also supported nics web page (http://dpdk.org/doc/nics), needs

updating

quoted

    (http://dpdk.org/browse/tools/dpdk-web/
    <http://dpdk.org/browse/tools/dpdk-web/>)


Not sure about this one. I could not find any file in the repo for
changing this. How should I manage it?

Please check [1], currently it lists NFP-6xxx only.

[1]
http://dpdk.org/browse/tools/dpdk-web/tree/doc/nics.html#n93

I did not realize there is a repo for this.

Thanks

quoted

    > +     },
    > +     {
    > +             RTE_PCI_DEVICE(PCI_VENDOR_ID_NETRONOME,
    >                              PCI_DEVICE_ID_NFP6000_PF_NIC)
    <...>