Thread (5 messages) read the whole thread 5 messages, 3 authors, 2017-10-09

Re: [PATCH v3] eal/linuxapp: check mmap return value MAP_FAILED

From: Sergio Gonzalez Monroy <hidden>
Date: 2017-08-29 08:31:40

On 28/08/2017 22:49, Seth Howell wrote:
quoted hunk ↗ jump to hunk
If mmap fails, it will return the value MAP_FAILED. Checking for this
return code allows us to properly identify mmap failures and report
them as such to the calling function.

Signed-off-by: Seth Howell <redacted>
---
  lib/librte_eal/linuxapp/eal/eal_memory.c | 2 ++
  1 file changed, 2 insertions(+)
diff --git a/lib/librte_eal/linuxapp/eal/eal_memory.c b/lib/librte_eal/linuxapp/eal/eal_memory.c
index 5279128..63fec29 100644
--- a/lib/librte_eal/linuxapp/eal/eal_memory.c
+++ b/lib/librte_eal/linuxapp/eal/eal_memory.c
@@ -716,6 +716,8 @@ create_shared_memory(const char *filename, const size_t mem_size)
  	}
  	retval = mmap(NULL, mem_size, PROT_READ | PROT_WRITE, MAP_SHARED, fd, 0);
  	close(fd);
+	if (retval == MAP_FAILED)
+		return NULL;
  	return retval;
  }
  
Acked-by: Sergio Gonzalez Monroy <redacted>
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help