Re: [PATCH] ethdev: modifiy vlan_offload_set_t to return int
From: David Harton (dharton) <hidden>
Date: 2017-08-25 00:55:23
-----Original Message----- From: Stephen Hemminger [mailto:stephen@networkplumber.org] Sent: Thursday, August 24, 2017 7:37 PM To: David Harton (dharton) <redacted> Cc: thomas@monjalon.net; ferruh.yigit@intel.com; stephen.hurd@broadcom.com; ajit.khaparde@broadcom.com; John Daley (johndale) [off-list ref]; wenzhuo.lu@intel.com; konstantin.ananyev@intel.com; jingjing.wu@intel.com; beilei.xing@intel.com; jing.d.chen@intel.com; adrien.mazarguil@6wind.com; nelio.laranjeiro@6wind.com; alejandro.lucero@netronome.com; hemant.agrawal@nxp.com; rasesh.mody@cavium.com; harish.patil@cavium.com; skhare@vmware.com; yliu@fridaylinux.org; maxime.coquelin@redhat.com; allain.legacy@windriver.com; dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH] ethdev: modifiy vlan_offload_set_t to return int On Thu, 24 Aug 2017 19:18:51 -0400 David Harton [off-list ref] wrote:quoted
@@ -2031,7 +2031,7 @@ struct avp_queue { mask = (ETH_VLAN_STRIP_MASK | ETH_VLAN_FILTER_MASK | ETH_VLAN_EXTEND_MASK); - avp_vlan_offload_set(eth_dev, mask); + (void)avp_vlan_offload_set(eth_dev, mask);This is a BSDism. You don't need the void cast.
Never know what to do...SA tools and some compilers whine if I don't. People complain if I do. :) What if I check the return code and log an error?