Re: [PATCH] crypto/openssl: performance improvements

Hi Akhil,

-----Original Message-----
From: Akhil Goyal [mailto:akhil.goyal@nxp.com]
Sent: Friday, July 28, 2017 12:08 PM
To: dev@dpdk.org; Doherty, Declan <redacted>
Cc: De Lara Guarch, Pablo <redacted>;
hemant.agrawal@nxp.com; Akhil Goyal [off-list ref]
Subject: [PATCH] crypto/openssl: performance improvements

key and algo are added in the openssl ctx during session initialization
instead of adding it for each packet.

Also in case of HMAC the openssl APIs HMAC_XXX give better performance
for all HMAC cases.

Signed-off-by: Akhil Goyal <redacted>

Thanks for the patch, nice optimization!
Could you split this into two patches, as you are doing two different things here?
One for the first sentence and another one for the second sentence.
Also, as you do that, could you rename the title to be more explicit?
Like: crypto/openssl: initialize cipher key at session init

Finally, I was looking at GCM, and I think it could benefit from this.
I will send a separate patch for it, unless you want to integrate it in this patchset yourself.

Thanks,
Pablo