Hi, Ferruh:

-----Original Message-----
From: Yigit, Ferruh
Sent: Wednesday, August 9, 2017 8:53 PM
To: Yang, Zhiyong <redacted>; dev@dpdk.org
Cc: thomas@monjalon.net
Subject: Re: [dpdk-dev] [PATCH 1/2] ethdev: increase port_id range

On 8/9/2017 9:42 AM, Zhiyong Yang wrote:

quoted

Extend port_id definition from uint8_t to uint16_t in lib ethdev data
structures, specifically rte_eth_dev_data and modify the APIs using
port_id at the same time.

Signed-off-by: Zhiyong Yang <redacted>
---
 app/pdump/main.c                           |   2 +-
 app/test-pmd/cmdline.c                     |   4 +-
 app/test-pmd/testpmd.c                     |   4 +-
 app/test-pmd/testpmd.h                     |   2 +-

quoted

 drivers/net/bonding/rte_eth_bond.h         |  40 ++---
 drivers/net/bonding/rte_eth_bond_8023ad.c  |   6 +-
 drivers/net/bonding/rte_eth_bond_api.c     |  54 +++----
 drivers/net/bonding/rte_eth_bond_pmd.c     |  10 +-
 drivers/net/bonding/rte_eth_bond_private.h |  36 ++---
 drivers/net/failsafe/failsafe_ether.c      |   4 +-
 drivers/net/failsafe/failsafe_private.h    |   4 +-
 drivers/net/ring/rte_eth_ring.c            |   2 +-

I would expect more drivers would be effected from this, almost all.

Most PMDs stores the dev->data->port_in in their private data and use this value
while updating mbuf field, those local storage also should be updated to u16 to
prevent data loss.

Can you please double check drivers, specially data->port_id usages?
I quickly checked null and pcap for example, both needs to be updated.

Also PMDs with PMD specific API are getting port_id as parameter, so they
should be updated too.

Thanks for your reminder.  I will double check them.

And I am getting build error for ixgbe and i40e for log type format, - via clang.

I see them just now and fix them later.

Thanks
Zhiyong

Thanks,
ferruh