Re: [PATCH v3 1/3] mk: add sensible default target with defconfig
From: Thomas Monjalon <hidden>
Date: 2017-08-03 22:39:51
From: Thomas Monjalon <hidden>
Date: 2017-08-03 22:39:51
07/06/2017 16:37, David Hunt:
Users can now use 'make defconfig' to generate a configuration using the most appropriate defaults for the current machine. <arch-machine-execenv-toolchain> arch taken from uname -m machine defaults to native execenv is taken from uname, Linux=linuxapp, otherwise bsdapp toolchain is taken from $CC -v to see which compiler to use Signed-off-by: David Hunt <redacted> Acked-by: Shreyansh Jain <redacted>
Looks to be a good idea if it is really automatic.
+ ${CC} -v 2>&1 | \
+ grep " version " | cut -d ' ' -f 1)Unfortunately, it depends on $CC which is not commonly exported. What about defaulting to gcc?
- @echo "Configuration done" + @echo "Configuration done using "$(shell basename \ + $(RTE_CONFIG_TEMPLATE) | sed "s/defconfig_//g")
RTE_CONFIG_TEMPLATE is not defined in this patch (and I do not see the benefit in next patch).