Re: [PATCH v2] service: fix shifts to operate on 64 bit integers
From: Thomas Monjalon <hidden>
Date: 2017-07-31 20:12:49
31/07/2017 18:38, Harry van Haaren:
This commit fixes shifts to an integer (1 << shift) which
is assumed to be a 32-bit integer. In this case, the shift is
variable and expected to be valid for 64-bit integers. Given that
the expectation to work with 64 bits exists, we must ensure that
the (1 << shift) one in that formula is actually a uin64_t.
The UINT64_C() macro portably adds the correct suffix to a constant,
informing the compiler that the value is to be assigned 64 bits.
The issue would only manifests when there were greater than 31
services registered.
Fixes: 21698354c832 ("service: introduce service cores concept")
Signed-off-by: Harry van Haaren <redacted>Applied, thanks