Re: [PATCH] net/virtio: fix MAC addr not correct read

On Fri, Jul 28, 2017 at 11:01:14PM +0000, Jianfeng Tan wrote:

When virtio-net devices are bound to uio_pci_generic, we get
the wrong mac addr by virtio PMD. The wrong mac addr is a
addr that is 4-byte left shift of the correct addr.

It's a regression bug introduced by the cleanup patch below.
The condition of if we set use_msix should be if msix is
actually enabled. Only to check if there is a capability list
is not enough. For example, binding a transitional device
to uio_pci_device would trigger the wrong assignment of use_msix.

To correct that, we also check the flags of msix capability to
make sure it's enabled.

Fixes: ee1843bd8907 ("net/virtio: remove redundant MSI-X detection")
Cc: stable@dpdk.org
Cc: Zhihong Wang <redacted>
Cc: Yuanhan Liu <redacted>
Cc: Maxime Coquelin <redacted>

Reported-by: Vipin Varghese <redacted>
Signed-off-by: Jianfeng Tan <redacted>

Applied to dpdk-next-virtio.

Thanks.

	--yliu