[PATCH v2 2/6] ethdev: properly check detach capability
From: Gaetan Rivet <hidden>
Date: 2017-07-26 13:36:13
Subsystem:
library code, the rest · Maintainers:
Andrew Morton, Linus Torvalds
This capability is not bound to which driver is handling the device, but whether the bus is able to unplug it. This check is already performed in rte_eal_dev_detach, there is no need to do it in the ether layer. Signed-off-by: Gaetan Rivet <redacted> --- lib/librte_ether/rte_ethdev.c | 10 ---------- 1 file changed, 10 deletions(-)
diff --git a/lib/librte_ether/rte_ethdev.c b/lib/librte_ether/rte_ethdev.c
index 8c365ed..805ef63 100644
--- a/lib/librte_ether/rte_ethdev.c
+++ b/lib/librte_ether/rte_ethdev.c@@ -367,16 +367,6 @@ rte_eth_dev_is_detachable(uint8_t port_id) RTE_ETH_VALID_PORTID_OR_ERR_RET(port_id, -EINVAL); - switch (rte_eth_devices[port_id].data->kdrv) { - case RTE_KDRV_IGB_UIO: - case RTE_KDRV_UIO_GENERIC: - case RTE_KDRV_NIC_UIO: - case RTE_KDRV_NONE: - case RTE_KDRV_VFIO: - break; - default: - return -ENOTSUP; - } dev_flags = rte_eth_devices[port_id].data->dev_flags; if ((dev_flags & RTE_ETH_DEV_DETACHABLE) && (!(dev_flags & RTE_ETH_DEV_BONDED_SLAVE)))
--
2.1.4